feat(Table): add FitAllColumnWidth instance method #6857

ArgoZhang · 2025-10-10T01:55:56Z

Link issues

fixes #6773

Summary By Copilot

Regression?

Yes
No

Risk

High
Medium
Low

Verification

Manual (required)
Automated

Packaging changes reviewed?

Yes
No
N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

Doc is updated/provided or not needed
Demo is updated/provided or not needed
Merge the latest code from the main branch

Summary by Sourcery

Enable programmatic auto-fitting of all table columns via a new FitAllColumnWidth method and enhance cell width calculation for accuracy.

New Features:

Add Table.FitAllColumnWidth C# method and corresponding JS function to automatically fit all column widths

Enhancements:

Improve calcCellWidth calculation to include border widths and an extra pixel for more accurate measurements

sourcery-ai · 2025-10-10T01:56:21Z

Reviewer's Guide

This PR introduces a new FitAllColumnWidth API that invokes a JavaScript routine to auto-fit every column in the table and refines the cell width calculation to account for border sizes.

Sequence diagram for FitAllColumnWidth API invocation

sequenceDiagram
participant CSharp as Table (C#)
participant JS as Table.razor.js
CSharp->>JS: Invoke fitAllColumnWidth(id)
JS->>JS: Get table by id
alt Table found
  JS->>JS: For each .col-resizer in table
  JS->>JS: autoFitColumnWidth(table, col)
end

File-Level Changes

Change	Details	Files
Implement JavaScript method to auto-fit all columns	Exported fitAllColumnWidth function Locate all .col-resizer elements and invoke autoFitColumnWidth asynchronously	`src/BootstrapBlazor/Components/Table/Table.razor.js`
Refine cell width calculation	Include border-left and border-right widths in total Add a 1px adjustment to avoid truncation	`src/BootstrapBlazor/Components/Table/Table.razor.js`
Expose FitAllColumnWidth in C# Table component	Added public async Task FitAllColumnWidth() method Invoke corresponding JS function via InvokeVoidAsync Provided XML documentation summary	`src/BootstrapBlazor/Components/Table/Table.razor.cs`

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#6773	Provide a public method at the Razor layer to automatically fit all variable-width columns in the Table component.	✅

Possibly linked issues

feat(Table): 能否为Table提供一个方法，调用后实现自动适配所有列的列宽 #6773: The PR adds a FitAllColumnWidth method to automatically adjust all table column widths, directly fulfilling the issue's request.
feat(Table): 能否为Table提供一个方法，调用后实现自动适配所有列的列宽 #6773: PR adds FitAllColumnWidth and modifies calcCellWidth to correctly include border width, fixing the column width deviation.
feat(Table): 能否为Table提供一个方法，调用后实现自动适配所有列的列宽 #6773: PR adds FitAllColumnWidth and corrects calcCellWidth to properly adjust all column widths, addressing the bug.

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

Copilot

Pull Request Overview

This PR adds a new instance method FitAllColumnWidth to the Table component that automatically fits all column widths to their content. The feature allows programmatic control over column width optimization for all columns at once.

Added a new public method FitAllColumnWidth() to the Table component C# class
Implemented corresponding JavaScript function fitAllColumnWidth() that iterates through all resizable columns and applies auto-fit logic
Updated the calculation logic to include border widths in column width calculations
Bumped version from 9.11.1-beta06 to 9.11.1

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
Table.razor.cs	Adds the public FitAllColumnWidth method that calls JavaScript interop
Table.razor.js	Implements fitAllColumnWidth function and improves width calculation logic
BootstrapBlazor.csproj	Updates version number from beta to release

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/BootstrapBlazor/Components/Table/Table.razor.js

src/BootstrapBlazor/Components/Table/Table.razor.cs

sourcery-ai

Hey there - I've reviewed your changes and they look great!

Prompt for AI Agents

Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `src/BootstrapBlazor/Components/Table/Table.razor.js:788-789` </location>
<code_context>
     const cellStyle = getComputedStyle(cell);
-    const width = div.offsetWidth + parseFloat(cellStyle.getPropertyValue('padding-left')) + parseFloat(cellStyle.getPropertyValue('padding-right'));
-    div.remove();
+    const width = div.offsetWidth + parseFloat(cellStyle.getPropertyValue('padding-left')) + parseFloat(cellStyle.getPropertyValue('padding-right')) + parseFloat(cellStyle.getPropertyValue('border-left-width')) + parseFloat(cellStyle.getPropertyValue('border-right-width')) + 1;
     return width;
 }
</code_context>

<issue_to_address>
**suggestion:** Adding a hardcoded '+ 1' to width calculation may introduce inconsistencies.

This change may cause off-by-one errors or misalignment. If it's addressing a specific rendering issue, please document the rationale or explore a more reliable fix.

```suggestion
    // Removed hardcoded '+ 1' to avoid off-by-one errors. If subpixel rendering causes issues, consider using Math.ceil().
    const width = Math.ceil(
        div.offsetWidth +
        parseFloat(cellStyle.getPropertyValue('padding-left')) +
        parseFloat(cellStyle.getPropertyValue('padding-right')) +
        parseFloat(cellStyle.getPropertyValue('border-left-width')) +
        parseFloat(cellStyle.getPropertyValue('border-right-width'))
    );
    return width;
```
</issue_to_address>

### Comment 2
<location> `src/BootstrapBlazor/Components/Table/Table.razor.js:788-789` </location>
<code_context>
    const width = div.offsetWidth + parseFloat(cellStyle.getPropertyValue('padding-left')) + parseFloat(cellStyle.getPropertyValue('padding-right')) + parseFloat(cellStyle.getPropertyValue('border-left-width')) + parseFloat(cellStyle.getPropertyValue('border-right-width')) + 1;
    return width;

</code_context>

<issue_to_address>
**suggestion (code-quality):** Inline variable that is immediately returned ([`inline-immediately-returned-variable`](https://docs.sourcery.ai/Reference/Rules-and-In-Line-Suggestions/JavaScript/Default-Rules/inline-immediately-returned-variable))

```suggestion
    return div.offsetWidth + parseFloat(cellStyle.getPropertyValue('padding-left')) + parseFloat(cellStyle.getPropertyValue('padding-right')) + parseFloat(cellStyle.getPropertyValue('border-left-width')) + parseFloat(cellStyle.getPropertyValue('border-right-width')) + 1;

```

<br/><details><summary>Explanation</summary>Something that we often see in people's code is assigning to a result variable
and then immediately returning it.

Returning the result directly shortens the code and removes an unnecessary
variable, reducing the mental load of reading the function.

Where intermediate variables can be useful is if they then get used as a
parameter or a condition, and the name can act like a comment on what the
variable represents. In the case where you're returning it from a function, the
function name is there to tell you what the result is, so the variable name
is unnecessary.
</details>
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

src/BootstrapBlazor/Components/Table/Table.razor.js

codecov · 2025-10-10T01:58:45Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (826819f) to head (e1a2ec3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #6857   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          739       739           
  Lines        31755     31758    +3     
  Branches      4466      4466           
=========================================
+ Hits         31755     31758    +3

Flag	Coverage Δ
BB	`100.00% <100.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ArgoZhang added 3 commits October 10, 2025 09:13

feat(Table): add FitAllColumnWidth instance method

ba8b3a5

refactor: 增加 border 宽度

9571e31

chore: bump version 9.11.1

8c8bc42

Copilot AI review requested due to automatic review settings October 10, 2025 01:55

bb-auto bot assigned ArgoZhang Oct 10, 2025

bb-auto bot added the enhancement New feature or request label Oct 10, 2025

bb-auto bot added this to the 9.11.0 milestone Oct 10, 2025

Copilot AI reviewed Oct 10, 2025

View reviewed changes

src/BootstrapBlazor/Components/Table/Table.razor.js Show resolved Hide resolved

src/BootstrapBlazor/Components/Table/Table.razor.cs Show resolved Hide resolved

sourcery-ai bot previously approved these changes Oct 10, 2025

View reviewed changes

src/BootstrapBlazor/Components/Table/Table.razor.js Show resolved Hide resolved

src/BootstrapBlazor/Components/Table/Table.razor.js Show resolved Hide resolved

test: 增加单元测试

e1a2ec3

ArgoZhang dismissed sourcery-ai[bot]’s stale review via e1a2ec3 October 10, 2025 02:09

ArgoZhang merged commit 951e97a into main Oct 10, 2025
7 checks passed

ArgoZhang deleted the feat-table branch October 10, 2025 02:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(Table): add FitAllColumnWidth instance method #6857

feat(Table): add FitAllColumnWidth instance method #6857

Uh oh!

ArgoZhang commented Oct 10, 2025 •

edited by sourcery-ai bot

Loading

Uh oh!

sourcery-ai bot commented Oct 10, 2025 •

edited

Loading

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

sourcery-ai bot left a comment

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Oct 10, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

feat(Table): add FitAllColumnWidth instance method #6857

feat(Table): add FitAllColumnWidth instance method #6857

Uh oh!

Conversation

ArgoZhang commented Oct 10, 2025 • edited by sourcery-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Link issues

Summary By Copilot

Regression?

Risk

Verification

Packaging changes reviewed?

☑️ Self Check before Merge

Summary by Sourcery

Uh oh!

sourcery-ai bot commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

Sequence diagram for FitAllColumnWidth API invocation

File-Level Changes

Assessment against linked issues

Possibly linked issues

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ArgoZhang commented Oct 10, 2025 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Oct 10, 2025 •

edited

Loading

codecov bot commented Oct 10, 2025 •

edited

Loading